-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to npm 7 #28115
Migrate to npm 7 #28115
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
NODB failure is unrelated 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Did you push the production or dev js? |
Yes, always have been 🔫 😉 server/.github/workflows/node.yml Lines 44 to 52 in 717636f
|
okay and shouldn't we wait until the tests finish? |
Finished! 🛎️ 😁 |
Yet another shot at it.
Lots of outdated sections 😩
I didn't change the babel config as this is causing export issues and make everything not defined:
dav is not defined
OC is not defined
etc etc. Most likely an issue with umd/commonjs exportsFollowups:
vue/no-mutating-props
server/.eslintrc.js
Line 18 in 7ca81f3