Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(session): Log when crypto session data is lost #40879

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Oct 11, 2023

Summary

I don't know if this ever happens, but logging it wouldn't be a bad idea, I guess?

The code then calls session_regenerate_id(true), which is known to cause lost sessions: https://www.php.net/manual/en/function.session-regenerate-id.php

Ref #24550

Checklist

@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst ChristophWurst merged commit 03c7ee4 into master Oct 12, 2023
36 of 39 checks passed
@ChristophWurst ChristophWurst deleted the fix/session/log-lost-crypto-session branch October 12, 2023 08:37
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ChristophWurst
Copy link
Member Author

/backport to stable27

1 similar comment
@ChristophWurst
Copy link
Member Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants