fix(session): Do not log fresh/empty session as error #41318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
1 task
ChristophWurst
commented
Nov 7, 2023
| 'exception' => $e, | ||
| ]); | ||
| if ($encryptedSessionData === '') { | ||
| // Nothing to decrypt | ||
| $this->sessionValues = []; |
There was a problem hiding this comment.
What I'm not entirely sure about is whether we need to regenerate the session ID here. But it seems useless if the session we currently have is empty anyway. Regenerating will more likely cause race conditions.
nickvergessen
approved these changes
Nov 10, 2023
AndyScherzinger
approved these changes
Nov 10, 2023
9 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regression was introduced with #40879.
Summary
An empty session can't be decrypted. We can safely ignore this condition and only log if a value is set and that value can't be decrypted.
How to test
Master: error is logged because the session file is empty.
Here: no error is logged.
Checklist