Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue migration: settings #8824

Merged
merged 39 commits into from
May 22, 2018
Merged

Vue migration: settings #8824

merged 39 commits into from
May 22, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 14, 2018

Features:

  • Form validation
    • New user form requires user+pass or user+email minimum
    • Validate every other fields:
      • displayname can be empty
      • password can't be empty and has the minlength requirement from the password policy if enabled
      • emails are validated as emails & can be empty
  • We switched to a grid design, no more ugly table
  • Hide/show columns settings are now saved in the browser, saving us some undesirable db entries
  • Only using our api, no more shady legacy ajax entry points
  • We only show 2 groups max, and add an indicator saying how many more are selected (better visual & consistency)
  • Password can't be change if encryption does NOT use a master key (safety reason)
  • Now using Vuejs, components are fresh and will be moved to a dedicated repo later on with proper documentation and tests
  • Language edition capability

Fix #642
Fix #7424
Fix #5752
Fix #5751
Fix #8862
Fix #9289
Fix #9191
Fix #8917
Fix #8010
Fix #4320

Settings

  • Design + base
  • Quota
  • Groups management
  • Subadmins management
  • User disablement
  • User deletion
  • Props edition (email, name...)
  • Server-side-ecrptn password change
  • Migrate to OCS api
  • Support password policy min length
  • Search support
  • Group deletion

Design

  • Better display of overflow tags
  • Themed vue-multiselect

Waiting for:

Components see #7738

  • Popovermenu v1
  • AppNavigation v1
  • Request api + authentification system

Bugs

  • On user deletion, if admin of group(s), db key(s) is/are not removed
  • All user count also includes disabled but they are not shown on the list
  • User old apppassword are not deleted on user deletion! ⚠️

Before merge:

@skjnldsv skjnldsv added enhancement design Design, UI, UX, etc. 2. developing Work in progress labels Mar 14, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Mar 14, 2018
@skjnldsv skjnldsv self-assigned this Mar 14, 2018
@codecov
Copy link

codecov bot commented Mar 15, 2018

Codecov Report

Merging #8824 into master will increase coverage by 0.01%.
The diff coverage is 22.94%.

@@             Coverage Diff              @@
##             master    #8824      +/-   ##
============================================
+ Coverage      51.7%   51.71%   +0.01%     
+ Complexity    25742    25671      -71     
============================================
  Files          1643     1634       -9     
  Lines         96501    95810     -691     
  Branches       1393     1381      -12     
============================================
- Hits          49895    49550     -345     
+ Misses        46606    46260     -346
Impacted Files Coverage Δ Complexity Δ
lib/private/NavigationManager.php 77.55% <0%> (ø) 51 <0> (ø) ⬇️
settings/templates/settings.php 0% <0%> (ø) 0 <0> (ø) ⬇️
settings/routes.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Settings/Personal/PersonalInfo.php 0% <0%> (ø) 16 <0> (-14) ⬇️
settings/Controller/UsersController.php 41.96% <30.76%> (-26.95%) 39 <22> (-81)
lib/private/L10N/Factory.php 60.82% <8.82%> (-11.57%) 88 <16> (+16)
settings/Application.php 50% <0%> (-20.69%) 14% <0%> (ø)
lib/private/Group/MetaData.php 71.62% <0%> (-5.41%) 19% <0%> (ø)
lib/private/LargeFileHelper.php 60.29% <0%> (-4.79%) 28% <0%> (+2%)
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
... and 6 more

settings/README.md Outdated Show resolved Hide resolved
settings/users.php Outdated Show resolved Hide resolved
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
- Gap between columns
- Click on icon more closes the menu
- Fixed select height
- Focus input on new user click
- Cursor fix on select

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
opened group and user removal update fix

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
* Fixed  subadmin group management
* Fixed pass policy prop retrieving
* Fixed fields subadmins were not supposed to see

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv
Copy link
Member Author

@nextcloud/designers bump :)

… added tooltip to groups +x indicator

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv
Copy link
Member Author

skjnldsv commented May 18, 2018

@michag86 small push to update the width of the groups list
Also: added a tooltip to show the full list on hover:
capture d ecran_2018-05-19_00-32-16

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works a lot better than before - some minor things for Edge and IE, but this is stuff for later 👍

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke merged commit a2c518e into master May 22, 2018
@MorrisJobke MorrisJobke deleted the settings-vue branch May 22, 2018 22:32
@danopz
Copy link

danopz commented May 23, 2018

Will the components be pushed to nextcloud/vue-components?

@skjnldsv
Copy link
Member Author

@danopz very soon yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants