Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added firefox profile option to acceptance tests with selenium and behat #9438

Closed
wants to merge 1 commit into from

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented May 9, 2018

@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews labels May 9, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone May 9, 2018
@skjnldsv skjnldsv self-assigned this May 9, 2018
@skjnldsv skjnldsv requested a review from danxuliu May 9, 2018 17:55
@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #9438 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9438      +/-   ##
============================================
+ Coverage     51.61%   51.61%   +<.01%     
+ Complexity    25694    25684      -10     
============================================
  Files          1638     1638              
  Lines         96315    96283      -32     
  Branches       1393     1393              
============================================
- Hits          49713    49697      -16     
+ Misses        46602    46586      -16
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.7% <0%> (+0.24%) 136% <0%> (ø) ⬇️
lib/private/legacy/api.php 35.41% <0%> (+1.04%) 31% <0%> (ø) ⬇️
lib/private/AppFramework/OCS/BaseResponse.php 80.76% <0%> (+4.9%) 4% <0%> (-10%) ⬇️
lib/private/legacy/json.php 12% <0%> (+12%) 19% <0%> (ø) ⬇️

@skjnldsv skjnldsv force-pushed the added-css-grid-and-firefox-profile-tests branch from 6bf6253 to 0d72d6b Compare May 10, 2018 05:51
@skjnldsv skjnldsv mentioned this pull request May 10, 2018
34 tasks
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 14, 2018
@danxuliu
Copy link
Member

Overriden by #9521

I created a different pull request instead of amending this one to leave it as future reference, just in case this technique is needed later. In any case note that currently this technique works only for acceptance tests run in local, but not for those run in Drone.

@danxuliu danxuliu closed this May 18, 2018
@danxuliu danxuliu deleted the added-css-grid-and-firefox-profile-tests branch May 18, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants