fix: fix crash in dataset list command on macos #576
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextstrain/nextclade/EkiMD5iwComBYq6HKfrm2reKU4Aw |
| @@ -394,7 +394,6 @@ namespace Nextclade { | |||
|
|
|||
| auto numTags = std::to_string(datasetRef.versions.size()); | |||
| fmt::format_to(buf, " Specific versions ({:}):\n", datasetRef.versions.size()); | |||
| fmt::format_to(buf, " ------------------" + std::string{"-", numTags.size() + 3} + "\n\n"); | |||
There was a problem hiding this comment.
This is the "fix".
This temporary string seems to be crashing on MacOS in Release mode only. fmt considers it an invalid string, but I cannot figure out why.
Removing this line for now, it is non-essential. But there might be some deeper problem elsewhere, like memory corruption or otherwise undefined behavior. It's C++ we need to be alert (or rewrite Nextclade in Rust).
Additionally I updated the fmt library to incorporate latest fixes, in case something was wrong there.
ivan-aksamentov
force-pushed
the
fix/dataset-list-crash
branch
from
0780fa2
to
b131f90
Compare
ivan-aksamentov
force-pushed
the
fix/dataset-list-crash
branch
from
b131f90
to
8586bed
Compare
This version introduces bugfixes and related api changes
|
@corneliusroemer A bit too early, I need to revert some of the temporary changes I mentioned above first. |
|
Oops, sorry, I won't merge again... |
|
It's okay, I submitted these as a follow up in #578 |
Resolves #575
In order to build on Mac, I had to upgrade conan to the latest version due to conan-io/conan-center-index#5197. And the latest version seems to be only available on pip, not brew.
In
f91247b(#576) I also adjusted the ci config to produce the binaries on non-release branch to be able to test the fix manually. This commit will be reverted before merge.