Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXtransformations adds units attribute to vector attribute #547

Closed
prjemian opened this issue Mar 12, 2017 · 4 comments
Closed

NXtransformations adds units attribute to vector attribute #547

prjemian opened this issue Mar 12, 2017 · 4 comments
Assignees
Milestone

Comments

@prjemian
Copy link
Contributor

prjemian commented Mar 12, 2017

This is an error (in both HDF5 and XML).

Neither HDF5 nor XML attributes can have attributes themselves. As-is, this would result in a specification where a data file would specify a vector attribute which would, by the specification now, have a units attribute which could be assigned a value compatible with NX_DIMENSIONLESS.

@prjemian prjemian added the bug label Mar 12, 2017
@prjemian prjemian added this to the NeXus definitions 3.3 milestone Mar 12, 2017
@prjemian prjemian self-assigned this Mar 12, 2017
@prjemian
Copy link
Contributor Author

prjemian commented Mar 12, 2017

Here is the code with the error:

	<attribute name="vector" units="NX_DIMENSIONLESS" type="NX_NUMBER">
		<doc>
			Three values that define the axis for this transformation.
			The axis should be normalized to unit length, making it
			dimensionless.  For ``rotation`` axes, the direction should be
			chosen for a right-handed rotation with increasing angle.
			For ``translation`` axes the direction should be chosen for
			increasing displacement.
		</doc>
		<dimensions rank="1" value="3" />
	</attribute>

@prjemian
Copy link
Contributor Author

Because is a design error that interrupts validation, it is high-priority to resolve.

@prjemian
Copy link
Contributor Author

suggest adding a vector_units attribute to provide the requested information

@zjttoefs
Copy link
Contributor

The documentation clearly states that vector is dimensionless. A units attribute is not required.

prjemian added a commit that referenced this issue Apr 5, 2017
…bute

fixes #547: defines ``vector_units`` attribute for NXtransformations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants