-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema update 555 #558
Schema update 555 #558
Conversation
We should bump the minor version number of the XML Schema. Here is the definition from
BUT, that will change the namespace and that can have consequences that affect anything that uses the XML Schema. Should we bump the minor version? Any other way to differentiate from the previous XML Schema? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the diff it all looks sensible to me. Since the tests pass this also appears to work. Good enough for me.
@yayahjb Comments? tacit approval is not satisfying |
I will examine the consequences of changing the minor version number without changing the namespace string. It may well be that we leave the namespace string as-is, at least for now. |
Sorry, forgot to comment on the version number. I would say: Bump it. |
NOTE: This is different than the "3.1" used in the XML namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. -- HJB
minOccurs
changed tooptional
locally:
utils/test_suite.py
passes and the Sphinx documentation builds