Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema update 555 #558

Merged
merged 8 commits into from
May 2, 2017
Merged

Schema update 555 #558

merged 8 commits into from
May 2, 2017

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Apr 9, 2017

locally: utils/test_suite.py passes and the Sphinx documentation builds

@prjemian
Copy link
Contributor Author

prjemian commented Apr 9, 2017

We should bump the minor version number of the XML Schema. Here is the definition from nxdl.xsd:

<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema"
targetNamespace="http://definition.nexusformat.org/nxdl/3.1"
xmlns:nx="http://definition.nexusformat.org/nxdl/3.1" 
elementFormDefault="qualified">

BUT, that will change the namespace and that can have consequences that affect anything that uses the XML Schema.

Should we bump the minor version? Any other way to differentiate from the previous XML Schema?

Copy link
Contributor

@zjttoefs zjttoefs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the diff it all looks sensible to me. Since the tests pass this also appears to work. Good enough for me.

@prjemian
Copy link
Contributor Author

@yayahjb Comments? tacit approval is not satisfying

@prjemian
Copy link
Contributor Author

I will examine the consequences of changing the minor version number without changing the namespace string. It may well be that we leave the namespace string as-is, at least for now.

@zjttoefs
Copy link
Contributor

Sorry, forgot to comment on the version number. I would say: Bump it.
We might get away not changing it, but having version numbers we're too afraid to ever change is a bit pointless. We will see what breaks and have to prepare that for future updates.

NOTE: This is different than the "3.1" used in the XML namespace.
Copy link
Contributor

@yayahjb yayahjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. -- HJB

@prjemian prjemian merged commit 4aa4215 into master May 2, 2017
@prjemian prjemian deleted the schema_update_555 branch June 21, 2017 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants