Properly implement DM room creation & retrieval #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nexy7574
requested changes
Feb 29, 2024
|
|
||
| room = self.rooms.get(response.room_id) | ||
| if not room: | ||
| raise RuntimeError("DM room %r was created, but could not be found in the room list!" % room_id) |
There was a problem hiding this comment.
Could you add documentation for the RuntimeError exception into the docstring? only ValueError and MessageException are documented at the moment
src/niobot/client.py
Outdated
| await self._send( | ||
| nio.DirectRoomsResponse, | ||
| 'PUT', | ||
| nio.Api._build_path( ["user", self.user_id, "account_data", "m.direct"], |
There was a problem hiding this comment.
The whitespace is a little odd here - could you run ruff check --fix and ruff format & push on your fork? just for styling consistency
src/niobot/client.py
Outdated
| ) | ||
| if isinstance(result, nio.RoomCreateError): | ||
| raise GenericMatrixError("Failed to create DM room", response=result) | ||
|
|
||
| dm_rooms = {} | ||
| dm_rooms[user_id] = [result.room_id] |
There was a problem hiding this comment.
Just being pedantic here but wouldn't it be cleaner to just do dm_rooms = {user_id: [result.room_id]}?
|
Fixed the comments. Not sure how to submit PR again. |
|
No need to re-submit, changes are automatically added to the PR :) |
|
All checks passed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for the send_message, get_dm_rooms, and create_dm_room functions.
I also added code to do a lazy check if there are rooms that are on the server, but not on the bot. I am not sure
why this is happening.
I added a call to set the m.direct type on the newly created dm_room. This is not really supported by
the nio-sdk library, which is missing the MDirectResponse type.