Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #292

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Fixes #292

merged 3 commits into from
Jun 12, 2023

Conversation

JoseEspinosa
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@github-actions
Copy link

github-actions bot commented Jun 12, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 837ee95

+| ✅ 158 tests passed       |+
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • system_exit - System.exit in WorkflowAtacseq.groovy: System.exit(1) [line 23]
  • system_exit - System.exit in WorkflowAtacseq.groovy: System.exit(1) [line 36]
  • system_exit - System.exit in WorkflowAtacseq.groovy: System.exit(1) [line 41]

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-12 11:06:38

@JoseEspinosa JoseEspinosa marked this pull request as ready for review June 12, 2023 11:04
Copy link
Contributor

@bjlang bjlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjlang bjlang merged commit b7d9871 into nf-core:dev Jun 12, 2023
@JoseEspinosa JoseEspinosa deleted the fixes branch June 22, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants