Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG.md #20

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Update CHANGELOG.md #20

merged 2 commits into from
Dec 19, 2023

Conversation

cmatKhan
Copy link
Collaborator

adding Friekerike Hanssen to the thank-yous in the changelog credits for the first release

@cmatKhan
Merge pull request #18 from nf-core/dev
2fad5c2 
1.0.0 release
@cmatKhan
Update CHANGELOG.md
ccea6e5 
adding Friekerike Hanssen to the thank-yous in the changelog credits for the first release
@github-actions GitHub Actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @cmatKhan,

It looks like this pull-request is has been made against the nf-core/callingcards master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/callingcards dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@cmatKhan cmatKhan changed the base branch from master to dev December 19, 2023 20:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ccea6e5

+| ✅ 161 tests passed       |+
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release

✅ Tests passed:

Run details

  • nf-core/tools version 2.11
  • Run at 2023-12-19 20:31:03

@cmatKhan cmatKhan merged commit 8e5f8f9 into dev Dec 19, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cmatKhan