Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matrixfilter #209

Closed
wants to merge 3 commits into from
Closed

Update matrixfilter #209

wants to merge 3 commits into from

Conversation

WackerO
Copy link
Collaborator

@WackerO WackerO commented Nov 29, 2023

Module update

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Nov 29, 2023

nf-core lint overall result: Passed ✅

Posted for pipeline commit 33f4652

+| ✅ 164 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-03 13:07:52

@WackerO
Copy link
Collaborator Author

WackerO commented Nov 30, 2023

This PR is waiting for #199 which adds round_df_columns to the report
Also close #153 with this PR!

@pinin4fjords
Copy link
Member

What's going on with this now @WackerO ? I only see the changelog update in the diffs. If it's no longer relevant could you close please?

@WackerO
Copy link
Collaborator Author

WackerO commented Jan 9, 2024

Hmm, I'm honestly not sure, was the module updated in some other PR in the meantime? But yes, I'll close this then.

@WackerO WackerO closed this Jan 9, 2024
@WackerO WackerO deleted the update_matfilter branch January 9, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants