Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nf-test to bedtools/sort - #3936 #5221

Merged
merged 2 commits into from
Mar 19, 2024
Merged

add nf-test to bedtools/sort - #3936 #5221

merged 2 commits into from
Mar 19, 2024

Conversation

vlebars
Copy link
Contributor

@vlebars vlebars commented Mar 19, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@vlebars vlebars self-assigned this Mar 19, 2024
adamrtalbot
adamrtalbot reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch the paths over, this makes the module portable!

modules/nf-core/bedtools/sort/tests/main.nf.test Outdated Show resolved Hide resolved
modules/nf-core/bedtools/sort/tests/main.nf.test Outdated Show resolved Hide resolved
@vlebars vlebars added this pull request to the merge queue Mar 19, 2024
@LouisLeNezet
Copy link
Contributor

Nicely done !

Merged via the queue into nf-core:master with commit 571a5fe Mar 19, 2024
11 checks passed
@vlebars vlebars deleted the bedtools_sort_test branch March 19, 2024 15:00
jvfe added a commit to jvfe/modules that referenced this pull request Mar 19, 2024
@jvfe
Merge branch 'master' into nf-test_phispy
e16f6f9 
* master:
  Fix test for FASTQ_FASTQC_UMITOOLS_FASTP which included an absolute path in the snapshot. (nf-core#5278)
  added new module lofraq/viterbi; solves new module: lofreq/viterbi nf-core#5158 (nf-core#5197)
  Update glimpse/phase output channel to phased_variants nf-core#5172 (nf-core#5174)
  Add module: GTFSORT (nf-core#5237)
  add nf-test to bedtools/sort - nf-core#3936 (nf-core#5221)
  addedd optional output channel for lib files (nf-core#5257)
vlebars added a commit to vlebars/modules that referenced this pull request Mar 20, 2024
@vlebars @adamrtalbot
add nf-test to bedtools/sort - nf-core#3936 (nf-core#5221)
745b01b 
* add nf-test to bedtools/sort - nf-core#3936

* Apply suggestions from code review

Co-authored-by: Adam Talbot <[email protected]>

---------

Co-authored-by: LE BARS Victor <[email protected]>
Co-authored-by: Adam Talbot <[email protected]>
tucano pushed a commit to tucano/modules that referenced this pull request Mar 20, 2024
@vlebars @adamrtalbot @tucano
add nf-test to bedtools/sort - nf-core#3936 (nf-core#5221)
405fe20 
* add nf-test to bedtools/sort - nf-core#3936

* Apply suggestions from code review

Co-authored-by: Adam Talbot <[email protected]>

---------

Co-authored-by: LE BARS Victor <[email protected]>
Co-authored-by: Adam Talbot <[email protected]>
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@vlebars @adamrtalbot @jennylsmith
add nf-test to bedtools/sort - nf-core#3936 (nf-core#5221)
578ebda 
* add nf-test to bedtools/sort - nf-core#3936

* Apply suggestions from code review

Co-authored-by: Adam Talbot <[email protected]>

---------

Co-authored-by: LE BARS Victor <[email protected]>
Co-authored-by: Adam Talbot <[email protected]>
alexnater pushed a commit to alexnater/nf-core-modules that referenced this pull request Mar 21, 2024
@vlebars @adamrtalbot
add nf-test to bedtools/sort - nf-core#3936 (nf-core#5221)
f7093c0 
* add nf-test to bedtools/sort - nf-core#3936

* Apply suggestions from code review

Co-authored-by: Adam Talbot <[email protected]>

---------

Co-authored-by: LE BARS Victor <[email protected]>
Co-authored-by: Adam Talbot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrtalbot adamrtalbot adamrtalbot left review comments

@LouisLeNezet LouisLeNezet LouisLeNezet approved these changes

@edmundmiller edmundmiller Awaiting requested review from edmundmiller edmundmiller is a code owner

@sruthipsuresh sruthipsuresh Awaiting requested review from sruthipsuresh

@drpatelh drpatelh Awaiting requested review from drpatelh

@chris-cheshire chris-cheshire Awaiting requested review from chris-cheshire

Assignees

@vlebars vlebars

Labels
nf-test Ready for Review
Projects
nf-test Migration
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlebars @LouisLeNezet @adamrtalbot