Skip to content

Commit

Permalink
Merge pull request #2768 from MatthiasZepper/download_image_naming_issue
Browse files Browse the repository at this point in the history
nf-core download: Create container image symlinks so images are still found, even if registry config diverges.
  • Loading branch information
MatthiasZepper authored Feb 29, 2024
2 parents e11bbbb + e64f1a7 commit c24b390
Show file tree
Hide file tree
Showing 4 changed files with 338 additions and 40 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,12 @@ jobs:
sudo add-apt-repository --remove ppa:git-core/ppa
sudo apt install -y git
- name: Set up Singularity
if: ${{ matrix.test == 'test_download.py'}}
uses: eWaterCycle/setup-singularity@931d4e31109e875b13309ae1d07c70ca8fbc8537 # v7
with:
singularity-version: 3.8.3

- name: Get current date
id: date
run: echo "date=$(date +'%Y-%m')" >> $GITHUB_ENV
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
- Remove obsolete editor settings in `devcontainer.json` and `gitpod.yml` ([#2795](https://github.com/nf-core/tools/pull/2795))
- Add nf-test test instructions to contributing and PR template ([#2807](https://github.com/nf-core/tools/pull/2807))

### Download

- Improved offline container image resolution by introducing symlinks, fixes issues [#2751](https://github.com/nf-core/tools/issues/2751), [#2644](https://github.com/nf-core/tools/issues/2644) and [demultiplex#164](https://github.com/nf-core/demultiplex/issues/164): ([#2768](https://github.com/nf-core/tools/pull/2768))

### Linting

### Components
Expand Down
Loading

0 comments on commit c24b390

Please sign in to comment.