Make outdir a mandatory parameter #1431
Conversation
| @@ -23,6 +23,8 @@ jobs: | |||
| workspace_id: ${{ secrets.TOWER_WORKSPACE_ID }} | |||
| access_token: ${{ secrets.TOWER_ACCESS_TOKEN }} | |||
| compute_env: ${{ secrets.TOWER_COMPUTE_ENV }} | |||
| pipeline: ${{ github.repository }} | |||
There was a problem hiding this comment.
Hmmm...where did this come from again?
There was a problem hiding this comment.
And should we add it to awstest.yml too?
There was a problem hiding this comment.
I saw it here and yes, as you nicely spotted it should also be added to awstest.yml
There was a problem hiding this comment.
I have lost track of where we are with these actions. @ewels I could swear we tested this stuff and had already updated the pipeline template? I'm confused.
There was a problem hiding this comment.
Ok. Given this code is in rnaseq on master and the Actions seems to be working I think we are good here.
There was a problem hiding this comment.
These lines were deliberately removed and should not have been added back here. Sorry I missed the ping fellas..
There was a problem hiding this comment.
Context - removed in #1395
This is because the new version of the Tower CLI tool needs the fully qualified GitHub URL now, instead of user/repo (which is what github.repository gives). The nf-core/tower-action does this properly by default now, but by specifying these in the template here we overwrite those defaults and break it.
Fixed in #1488
|
Looks like this broke the python tests. Nobody noticed as those tests only run if python files are edited.. I'll change that now so that they always run. |
Make
outdira mandatory parameter. Closes #1415PR checklist
CHANGELOG.mdis updated