Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quay.io detection in simple docker names #2281

Merged
merged 2 commits into from
May 5, 2023
Merged

Fix quay.io detection in simple docker names #2281

merged 2 commits into from
May 5, 2023

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented May 5, 2023 •
edited
Loading

Detects docker name by single slash and colon in string.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Fixes #2280

@adamrtalbot
Fix: Detect docker name and append quay.io
1f9caf5 
Changes:
 - Detects simple docker name by having a single slash and colon in the
   string
 - adds quay.io as default registry for this docker container
 - Should fix problems where nfcore/ubuntu:20.04 did not find correct
   URL

fixes nf-core#2280
@adamrtalbot
CHANGELOG
0981732
@adamrtalbot adamrtalbot requested a review from drpatelh May 5, 2023 13:57
@drpatelh drpatelh merged commit 1edabeb into nf-core:dev May 5, 2023
@adamrtalbot
Copy link
Contributor Author

Thanks @FriederikeHanssen and @drpatelh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sateeshperi sateeshperi sateeshperi left review comments

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@drpatelh drpatelh Awaiting requested review from drpatelh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamrtalbot @FriederikeHanssen @sateeshperi @drpatelh