Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: the actual pipeline name should be shown #2291

Merged
merged 3 commits into from
May 15, 2023
Merged

Conversation

muffato
Copy link
Member

@muffato muffato commented May 15, 2023

sanger-tol/readmapping is the name of the pipeline I used to test the feature. Sorry about that !

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@github-actions
Copy link
Contributor

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @muffato,

It looks like this pull-request is has been made against the nf-core/tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@muffato muffato changed the base branch from master to dev May 15, 2023 08:51
@muffato muffato marked this pull request as ready for review May 15, 2023 08:52
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #2291 (bd10e58) into dev (2dc8d24) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2291   +/-   ##
=======================================
  Coverage   73.12%   73.12%           
=======================================
  Files          77       77           
  Lines        8433     8433           
=======================================
  Hits         6167     6167           
  Misses       2266     2266           

@muffato muffato merged commit 733dd81 into dev May 15, 2023
@muffato muffato deleted the muffato-patch-1 branch May 15, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants