Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add apptainer.registry #2352

Merged
merged 3 commits into from
Jun 30, 2023
Merged

add apptainer.registry #2352

merged 3 commits into from
Jun 30, 2023

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

ewels
ewels approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the speedy PR!

ewels
ewels requested changes Jun 30, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog

mirpedrol
mirpedrol approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@maxulysse
Copy link
Member Author

And we have a CHANGELOG even

mirpedrol
mirpedrol reviewed Jun 30, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@maxulysse @mirpedrol
Update CHANGELOG.md
de0c247 
Co-authored-by: Júlia Mir Pedrol <[email protected]>
@maxulysse maxulysse merged commit fb4801b into dev Jun 30, 2023
17 of 19 checks passed
@maxulysse maxulysse deleted the apptainer branch June 30, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

@ewels ewels ewels requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @ewels @mirpedrol