Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs to create test yml #2476

Merged
merged 8 commits into from
Oct 18, 2023

Conversation

nvnieuwk
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2476 (efe344a) into dev (66dbf0b) will decrease coverage by 0.08%.
Report is 2 commits behind head on dev.
The diff coverage is 51.61%.

@@            Coverage Diff             @@
##              dev    #2476      +/-   ##
==========================================
- Coverage   70.63%   70.56%   -0.08%     
==========================================
  Files          87       87              
  Lines        9460     9471      +11     
==========================================
+ Hits         6682     6683       +1     
- Misses       2778     2788      +10     
Files Coverage Δ
nf_core/modules/test_yml_builder.py 49.77% <50.00%> (-1.14%) ⬇️
nf_core/subworkflows/test_yml_builder.py 48.16% <52.94%> (-0.80%) ⬇️

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just a small comment, what do you think about making the stub test the last one instead of the first?

@nvnieuwk nvnieuwk merged commit 8d0e1f3 into nf-core:dev Oct 18, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants