Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-test linting tags #2572

Merged
merged 4 commits into from
Dec 14, 2023
Merged

nf-test linting tags #2572

merged 4 commits into from
Dec 14, 2023

Conversation

mirpedrol
Copy link
Member

All components used in chained nf-tests, defined with script in the file main.nf.test must be added to the tags.
Close #2559

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! Do we have any pytests that test this already with any of our modules/subworkflows?

@mirpedrol
Copy link
Member Author

Do we have any pytests that test this already with any of our modules/subworkflows?

Not yet, I will add a chained module to our tests 👍

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d1994a7) 74.94% compared to head (960bff5) 74.98%.

Files Patch % Lines
nf_core/components/nfcore_component.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2572      +/-   ##
==========================================
+ Coverage   74.94%   74.98%   +0.03%     
==========================================
  Files          85       85              
  Lines        9309     9327      +18     
==========================================
+ Hits         6977     6994      +17     
- Misses       2332     2333       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol mirpedrol merged commit fcf0c7e into nf-core:dev Dec 14, 2023
20 checks passed
@mirpedrol mirpedrol deleted the lint-nftest-tags branch December 14, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants