Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev -> Master for 2.11.1 #2615

Merged
merged 23 commits into from
Dec 20, 2023
Merged

Dev -> Master for 2.11.1 #2615

merged 23 commits into from
Dec 20, 2023

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Dec 20, 2023

No description provided.

renovate bot and others added 22 commits December 19, 2023 18:10
Update pre-commit hook psf/black to v23.12.0
it should be docker.runOptions
rename release-announcments.yml to release-announcements.yml
only dump modules.json when it is modified
…23.x

Revert "Update pre-commit hook psf/black to v23.12.0"
bump version for patch release
Generate new screengrabs with rich-codex
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (26e43b5) 75.02% compared to head (d52fda0) 75.01%.
Report is 4 commits behind head on master.

Files Patch % Lines
nf_core/modules/modules_json.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2615      +/-   ##
==========================================
- Coverage   75.02%   75.01%   -0.02%     
==========================================
  Files          85       85              
  Lines        9376     9384       +8     
==========================================
+ Hits         7034     7039       +5     
- Misses       2342     2345       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one had changed a lot, is that expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, all of them are improvements to before 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one had changed a lot, is that expected?

@maxulysse
Copy link
Member

how come we have the message:

This branch is out-of-date with the base branch

.gitpod.yml Outdated Show resolved Hide resolved
Co-authored-by: Júlia Mir Pedrol <[email protected]>
@mashehu mashehu merged commit 50d56f6 into master Dec 20, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants