Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules: keep custom *.config files also after nf-core modules/subworkflows update #2763

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Modules: keep custom *.config files also after nf-core modules/subworkflows update #2763

merged 4 commits into from
Feb 19, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Feb 16, 2024 •
edited
Loading

Closes #2658

@codecov Codecov
Copy link

codecov bot commented Feb 16, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2dd530e) 73.46% compared to head (6b65a01) 73.49%.
Report is 48 commits behind head on dev.

Files Patch % Lines
nf_core/components/update.py 78.94% 4 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu mashehu changed the title Modules: ask if additional files should be moved over during nf-core modules/subworkflows update Modules: keep nextflow.config during nf-core modules/subworkflows update Feb 19, 2024
@mashehu
Copy link
Contributor Author

mashehu commented Feb 19, 2024

@nf-core-bot changelog

mirpedrol
mirpedrol approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nf_core/components/update.py Outdated Show resolved Hide resolved
@mashehu mashehu changed the title Modules: keep nextflow.config during nf-core modules/subworkflows update Modules: keep custom *.config files also after nf-core modules/subworkflows update Feb 19, 2024
@mashehu
Copy link
Contributor Author

mashehu commented Feb 19, 2024

@nf-core-bot changelog

@mashehu mashehu merged commit a47369a into nf-core:dev Feb 19, 2024
35 checks passed
@mirpedrol mirpedrol mentioned this pull request Feb 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mashehu @mirpedrol