Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template config: conda.channels, not channels #2950

Merged
merged 3 commits into from
May 5, 2024
Merged

Template config: conda.channels, not channels #2950

merged 3 commits into from
May 5, 2024

Conversation

ewels
Copy link
Member

@ewels ewels commented May 3, 2024

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels

This comment was marked as resolved.

Sign in to view
@codecov Codecov

This comment was marked as resolved.

Sign in to view
@ewels
Copy link
Member Author

ewels commented May 3, 2024

False alarm - the code I linked to above is just for Wave (well spotted @tillenglert). So this PR should be good to go.

Test failures seem unrelated. Any ideas @mashehu @mirpedrol ?

@maxulysse
Copy link
Member

maxulysse commented May 3, 2024 •
edited
Loading

Test failures seem unrelated. Any ideas @mashehu @mirpedrol ?

lint fails when a subworkflow is not up to date, that's a tools issue

@ewels ewels merged commit 1bde816 into dev May 5, 2024
35 checks passed
@ewels ewels deleted the conda.channels-fix branch May 5, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ewels @maxulysse @mashehu @nf-core-bot