Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less strict logo comparison #2956

Merged
merged 5 commits into from
May 7, 2024
Merged

Less strict logo comparison #2956

merged 5 commits into from
May 7, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented May 7, 2024

Hopefully should resolve more of the linting issues

@mashehu mashehu requested a review from mirpedrol May 7, 2024 12:39
mirpedrol
mirpedrol approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.28%. Comparing base (fc78f07) to head (7067afe).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu mashehu merged commit dda0b91 into nf-core:dev May 7, 2024
35 checks passed
@mashehu mashehu deleted the less-strict-logo-compare branch May 7, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mashehu @mirpedrol @nf-core-bot