Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode settings #3192

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Vscode settings #3192

merged 4 commits into from
Nov 15, 2024

Conversation

ewels
Copy link
Member

@ewels ewels commented Oct 4, 2024

Get nf-core/website#2579 but for pipelines.

Not sure if it's going to cause trouble adding a .vscode directory into pipelines? 👀 Happy to have this closed if people are concerned.

This comment was marked as resolved.

@mashehu mashehu changed the base branch from master to dev October 4, 2024 13:34
Needed to set the vscode_markdown.css path for Extended Markdown previews of docs.

Signed-off-by: Phil Ewels <[email protected]>
@ewels
Copy link
Member Author

ewels commented Oct 4, 2024

@mirpedrol I guess this probably needs to be made skippable etc by the template creation if we decide we want to add it 😬

@mirpedrol
Copy link
Member

I'm happy that the new testtest_template_customisation_all_files_grouping is working 😄 telling us that we added a new file to the template which is not skippable.
I would postpone this to 3.1.0

@ewels ewels added this to the 3.1 milestone Oct 4, 2024
@mirpedrol
Copy link
Member

@nf-core-bot update snapshots

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and all tests passing now :)

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.70%. Comparing base (d26c3e9) to head (9321971).
Report is 5 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewels ewels merged commit c5cd95c into nf-core:dev Nov 15, 2024
85 checks passed
@ewels ewels deleted the vscode-settings branch November 15, 2024 14:25
@mashehu
Copy link
Contributor

mashehu commented Nov 15, 2024

I will redirect all the editor warriors to you, @ewels

@ewels
Copy link
Member Author

ewels commented Nov 16, 2024

Happy to revert if you think it's a bad idea!

@mashehu
Copy link
Contributor

mashehu commented Nov 16, 2024

When one runs nextflow run is that file also coming along with the pipeline? Just feels like quite a tiny user group to serve in all pipelines. Mentioning it in the docs should be enough imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants