-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vscode settings #3192
Vscode settings #3192
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Needed to set the vscode_markdown.css path for Extended Markdown previews of docs. Signed-off-by: Phil Ewels <[email protected]>
@mirpedrol I guess this probably needs to be made skippable etc by the template creation if we decide we want to add it 😬 |
I'm happy that the new test |
@nf-core-bot update snapshots |
d3b3ae2
to
9321971
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and all tests passing now :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
I will redirect all the editor warriors to you, @ewels |
Happy to revert if you think it's a bad idea! |
When one runs nextflow run is that file also coming along with the pipeline? Just feels like quite a tiny user group to serve in all pipelines. Mentioning it in the docs should be enough imo |
Get nf-core/website#2579 but for pipelines.
Not sure if it's going to cause trouble adding a
.vscode
directory into pipelines? 👀 Happy to have this closed if people are concerned.