Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/wafv5 cfgmgr enfrcr #6169

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Docs/wafv5 cfgmgr enfrcr #6169

merged 6 commits into from
Aug 13, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Aug 12, 2024 •
edited
Loading

Proposed changes

Screenshot 2024-08-12 at 15 34 14

  • Add NIC WAF v5 matrix

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners August 12, 2024 14:35
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Aug 12, 2024
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6169/

@vepatel vepatel added the needs cherry pick Cherry pick this PR into a release branch label Aug 12, 2024
@vepatel
Copy link
Contributor Author

vepatel commented Aug 12, 2024

@Jcahilltorre @shaun-nx both the statements above are same in different locations, which one should be published?

Jcahilltorre
Jcahilltorre approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@Jcahilltorre Jcahilltorre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with suggestions

@Jcahilltorre
Copy link
Contributor

@Jcahilltorre @shaun-nx both the statements above are same in different locations, which one should be published?

I updated both to have the same content

vepatel and others added 2 commits August 12, 2024 16:52
@vepatel @Jcahilltorre
update based on review comments
fe927df 
Co-authored-by: Jon Torre <[email protected]>
Signed-off-by: Venktesh Shivam Patel <[email protected]>
@vepatel @Jcahilltorre
update based on review comments
6cb6109 
Co-authored-by: Jon Torre <[email protected]>
Signed-off-by: Venktesh Shivam Patel <[email protected]>
@vepatel vepatel enabled auto-merge (squash) August 12, 2024 15:55
@shaun-nx shaun-nx self-requested a review August 13, 2024 08:51
@shaun-nx shaun-nx mentioned this pull request Aug 13, 2024
Open
@vepatel vepatel merged commit ecb5b9b into main Aug 13, 2024
49 checks passed
@vepatel vepatel deleted the docs/wafv5-cfgmgr-enfrcr branch August 13, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaun-nx shaun-nx shaun-nx approved these changes

@Jcahilltorre Jcahilltorre Jcahilltorre approved these changes

@ADubhlaoich ADubhlaoich Awaiting requested review from ADubhlaoich

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @Jcahilltorre @shaun-nx