Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken URLs in documentation #2474

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix broken URLs in documentation #2474

merged 2 commits into from
Aug 28, 2024

Conversation

nginx-aoife
Copy link
Contributor

Proposed changes

Fix 2 broken URLs in Docs
Attached video shows locally built docs with the fix

Untitled19.mp4

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@nginx-aoife nginx-aoife requested review from a team as code owners August 28, 2024 11:03
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (ad76033) to head (2f7c984).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2474      +/-   ##
==========================================
+ Coverage   88.76%   88.79%   +0.02%     
==========================================
  Files         100      100              
  Lines        7531     7531              
  Branches       50       50              
==========================================
+ Hits         6685     6687       +2     
+ Misses        789      788       -1     
+ Partials       57       56       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman
Copy link
Contributor

Thanks @nginx-aoife, once this is merged, let's cherry-pick to the release-1.4 branch and then we can publish it to the public docs.

@nginx-aoife
Copy link
Contributor Author

@sjberman I don't have merge permissions (yet) on this repo. Can you merge it?

@sjberman sjberman enabled auto-merge (squash) August 28, 2024 14:27
@sjberman sjberman merged commit d18e073 into nginxinc:main Aug 28, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants