Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick URL fixes into Release 1.4 #2479

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

nginx-aoife
Copy link
Contributor

Proposed changes

Cherry pick MR #2474 into Release-1.4 branch

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@nginx-aoife nginx-aoife requested review from a team as code owners August 29, 2024 08:54
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 29, 2024
@nginx-aoife
Copy link
Contributor Author

@salonichf5 here is the cherry pick PR into the release-1.4 branch.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (8e653d6) to head (87c7b99).
Report is 1 commits behind head on release-1.4.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.4    #2479   +/-   ##
============================================
  Coverage        88.84%   88.84%           
============================================
  Files              100      100           
  Lines             7527     7527           
  Branches            50       50           
============================================
  Hits              6687     6687           
  Misses             784      784           
  Partials            56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sjberman sjberman merged commit d85a6ca into nginxinc:release-1.4 Aug 29, 2024
34 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants