Set Accepted condition type on Gateway status #633
Merged
+830
−548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjberman
reviewed
May 9, 2023
sjberman
approved these changes
May 9, 2023
pleshakov
suggested changes
May 9, 2023
@pleshakov I updated the docs |
github-actions
bot
added
the
documentation
kate-osborn
force-pushed
the
feat/gw-accepted
branch
from
40cb30e
to
63b6d4d
Compare
pleshakov
suggested changes
May 16, 2023
kate-osborn
force-pushed
the
feat/gw-accepted
branch
from
e993128
to
72e1ecf
Compare
kate-osborn
commented
May 17, 2023
pleshakov
approved these changes
May 17, 2023
The gocyclo linter complained about the complexity of the bindRouteToListeners function. This commit refactors this function to reduce its complexity.
kate-osborn
force-pushed
the
feat/gw-accepted
branch
from
72e1ecf
to
d5ec72b
Compare
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #368
Sets Accepted condition type on Gateway status. Accepted can be
true/falseand the following reasons are used:ListenersNotValid,Invalid,GatewayConflict, andAccepted.The
Invalidreason is used when the GatewayClass for the Gateway is missing or invalid. In this case, both the Gateway and all its listeners are considered invalid. No additional validation is performed for the listeners. The Gateway and its listeners will have the conditionAccepted/false/Invalidset on their statuses.This PR also replaces the
ListenerUnsupportedAddressCondition reason with theListenerUnsupportedValuereason to be consistent with the rest of our unsupported fields.