Fix binding to multiple listeners with empty section name #730
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
A refactor of the route binding logic done in #633 introduced a bug with empty section name. This PR fixes that bug.
Problem: If an HTTPRoute has a parentRef with an empty section name, and the referenced gateway has multiple valid listeners, the route would only bind to the first listener.
Solution: Attempt to bind to every valid listener in the referenced Gateway.
Testing: Added a unit test that reproduced the issue and manually verified that a route with empty section name can attach to multiple valid listeners.
Checklist
Before creating a PR, run through this checklist and mark each as complete.