Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table allows configuration of icon column type #1013

Closed
1 task done
nate-ni opened this issue Jan 30, 2023 · 0 comments
Closed
1 task done

Table allows configuration of icon column type #1013

nate-ni opened this issue Jan 30, 2023 · 0 comments
Assignees
@rajsite @m-akinc
Labels
enhancement New feature or request
Milestone
Table Milestone 5

Comments

@nate-ni
Copy link
Contributor

nate-ni commented Jan 30, 2023 •
edited by jattasNI
Loading

😯 Problem to Solve

💁 Proposed Solution

Open questions:

  1. which column width modes should it support? Just fixed pixel width?
@nate-ni nate-ni added enhancement New feature or request triage New issue that needs to be reviewed labels Jan 30, 2023
@nate-ni nate-ni added this to the Table Milestone 2 milestone Jan 30, 2023
@nate-ni nate-ni mentioned this issue Jan 31, 2023
Closed
1 task
@jattasNI jattasNI removed the triage New issue that needs to be reviewed label Jan 31, 2023
@nate-ni nate-ni mentioned this issue Feb 1, 2023
Closed
@jattasNI jattasNI mentioned this issue Mar 1, 2023
Closed
5 tasks
@atmgrifter00 atmgrifter00 mentioned this issue Mar 7, 2023
Closed
@m-akinc m-akinc self-assigned this Apr 28, 2023
@m-akinc m-akinc mentioned this issue May 1, 2023
Merged
1 task
m-akinc added a commit that referenced this issue May 30, 2023
@m-akinc @rajsite @atmgrifter00
Mapping table column spec (#1220)
b69c11c 
## 🤨 Rationale

See issues #1013 and #1103

## 👩‍💻 Implementation

This is a spec.

## 🧪 Testing

N/A

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Milan Raj <[email protected]>
Co-authored-by: Jonathan Meyer <[email protected]>
@m-akinc m-akinc mentioned this issue May 30, 2023
Closed
1 task
@m-akinc m-akinc mentioned this issue Aug 3, 2023
Merged
1 task
m-akinc added a commit that referenced this issue Aug 21, 2023
@m-akinc @atmgrifter00
Icon table column (#1418)
4f0f474 
## 🤨 Rationale

Part of #1013

## 👩‍💻 Implementation

Created new `nimble-table-column-icon` component plus the supporting
elements `nimble-mapping-icon` and `nimble-mapping-spinner`.

Angular and Blazor support will be implemented in follow-on PRs.

## 🧪 Testing

Unit tests written for all new components. Tested in Storybook.

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Jonathan Meyer <[email protected]>
@m-akinc m-akinc mentioned this issue Aug 22, 2023
Merged
1 task
m-akinc added a commit that referenced this issue Aug 24, 2023
@m-akinc
Angular support for icon table column (#1448)
d3f5a24 
## 🤨 Rationale

Part of #1013

## 👩‍💻 Implementation

- Created directive, module, and tests for `nimble-table-column-icon`,
`nimble-mapping-icon`, and `nimble-mapping-spinner`.
- Added icon column to example app.

## 🧪 Testing

Wrote standard tests for Angular directives.

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
@m-akinc m-akinc mentioned this issue Aug 24, 2023
Merged
1 task
rajsite pushed a commit that referenced this issue Aug 31, 2023
@m-akinc @mollykreis
Blazor support for icon table column (#1452)
49a4b98 
# Pull Request

## 🤨 Rationale

Part of #1013

## 👩‍💻 Implementation

- Blazor components for nimble-table-column-icon, nimble-mapping-icon,
and nimble-mapping-spinner
- Tests for above components, including one acceptance test for icon
column
- Added icon column to example app
- Created shared base type for both icon column and enum-text column
- Updated Storybook docs for icon column and enum-text column to explain
workaround to issue in Blazor where the key value of a mapping element
isn't property treated as a string unless you wrap it like this:
`@("foo")`.

## 🧪 Testing

Automated tests pass and example app works correctly.

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: mollykreis <[email protected]>
@m-akinc m-akinc closed this as completed Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajsite rajsite

@m-akinc m-akinc

Labels
enhancement New feature or request
Projects
Nimble Design System Priorities
Status: Done
Milestone
Table Milestone 5
Development

No branches or pull requests
4 participants
@rajsite @m-akinc @jattasNI @nate-ni