Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapping table column spec #1220

Merged
merged 31 commits into from
May 30, 2023
Merged

Mapping table column spec #1220

merged 31 commits into from
May 30, 2023

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented May 1, 2023

Pull Request

🤨 Rationale

See issues #1013 and #1103

👩‍💻 Implementation

This is a spec.

🧪 Testing

N/A

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

mollykreis
mollykreis reviewed May 4, 2023
View reviewed changes
packages/nimble-components/src/table/specs/table-column-specs/table-column-mapping.md Outdated Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-mapping.md Outdated Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-mapping.md Outdated Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-mapping.md Outdated Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-mapping.md Outdated Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-mapping.md Outdated Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-mapping.md Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-mapping.md Outdated Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-mapping.md Outdated Show resolved Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-mapping.md Outdated Show resolved Hide resolved
@m-akinc m-akinc requested a review from atmgrifter00 May 15, 2023 21:10
@m-akinc m-akinc requested a review from mollykreis May 19, 2023 15:05
@m-akinc m-akinc requested a review from rajsite May 23, 2023 19:53
@m-akinc m-akinc requested a review from rajsite May 24, 2023 15:59
@m-akinc m-akinc requested a review from mollykreis May 25, 2023 14:19
@m-akinc m-akinc merged commit b69c11c into main May 30, 2023
@m-akinc m-akinc deleted the users/makinc/icon-column-spec branch May 30, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite rajsite approved these changes

@jattasNI jattasNI jattasNI approved these changes

@mollykreis mollykreis mollykreis approved these changes

@atmgrifter00 atmgrifter00 atmgrifter00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@m-akinc @rajsite @jattasNI @mollykreis @atmgrifter00