Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Firefox and Webkit tests due to webcompat dialog issue #1936

Open
jattasNI opened this issue Mar 15, 2024 · 0 comments
Open

Disabled Firefox and Webkit tests due to webcompat dialog issue #1936

jattasNI opened this issue Mar 15, 2024 · 0 comments
Labels
blocked Blocked on a third-party issue tech debt

Comments

@jattasNI
Copy link
Contributor

jattasNI commented Mar 15, 2024

🧹 Tech Debt

Several dialog and drawer tests have been disabled in Firefox and Webkit due to dialogs not properly focusing shadow DOM content in those browsers.

Tracked by:

Here is a sample of the failures:

Drawer with default setup focuses the first button on the drawer when it opens FAILED
Expected ... to be .... Tip: To check for deep equality, use .toEqual() instead of .toBe().
Drawer with default setup supports opening multiple drawers on top of each other FAILED
Expected ... to be .... Tip: To check for deep equality, use .toEqual() instead of .toBe().
Drawer with default setup focuses the button with autofocus when the drawer opens FAILED
Expected ... to be .... Tip: To check for deep equality, use .toEqual() instead of .toBe().
Dialog focuses the button with autofocus when the dialog opens FAILED
Expected ... to be .... Tip: To check for deep equality, use .toEqual() instead of .toBe().5#step:17:45)
Dialog supports opening multiple dialogs on top of each other FAILED
Expected ... to be .... Tip: To check for deep equality, use .toEqual() instead of .toBe().
Dialog focuses the first button on the dialog when it opens FAILED
Expected ... to be .... Tip: To check for deep equality, use .toEqual() instead of .toBe().
@jattasNI jattasNI added blocked Blocked on a third-party issue tech debt triage New issue that needs to be reviewed labels Mar 15, 2024
rajsite added a commit that referenced this issue Mar 18, 2024
# Pull Request

## 🤨 Rationale

One of the tasks in #1747 is to run nimble-components tests in WebKit
and see if there are any new failures. There are several.

We also wanted to start tracking specific issues for each root cause
rather than catch all issues like #1074 and #1075.

## 👩‍💻 Implementation

Marked each failing test with one of these specific issues:
- #1936
- #1938 TODO: ALSO FILE AZDO BUG
- #1939 
- #1940 
- #1942 
- #1943

Also re-enabled a couple of table header tests in Firefox which are now
passing.

## 🧪 Testing

Ran tests in Playwright webkit browser, Firefox, and Safari and and all
the enabled tests now pass.

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Milan Raj <[email protected]>
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Mar 19, 2024
rajsite pushed a commit that referenced this issue Apr 8, 2024
# Pull Request

## 🤨 Rationale

The tests that were marked as being skipped in Firefox and Webkit
because of #1943 are failing in those browsers for the same reason
described in more detail in #1936. Therefore, I'm updating the comments
to reference #1936 and closing #1943 as a duplicate.

Closes #1943

## 👩‍💻 Implementation

Update comment to point to different issue

## 🧪 Testing

N/A

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [ ] I have updated the project documentation to reflect my changes or
determined no changes are needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on a third-party issue tech debt
Projects
Status: Backlog
Development

No branches or pull requests

2 participants