Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue referenced in skipped tests #2000

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

mollykreis
Copy link
Contributor

Pull Request

🤨 Rationale

The tests that were marked as being skipped in Firefox and Webkit because of #1943 are failing in those browsers for the same reason described in more detail in #1936. Therefore, I'm updating the comments to reference #1936 and closing #1943 as a duplicate.

Closes #1943

👩‍💻 Implementation

Update comment to point to different issue

🧪 Testing

N/A

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis mollykreis marked this pull request as ready for review April 5, 2024 19:39
Copy link
Contributor

@m-akinc m-akinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward. Shouldn't need further review.

@rajsite rajsite merged commit 2ab62c6 into main Apr 8, 2024
13 checks passed
@rajsite rajsite deleted the update-skip-test-comments branch April 8, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawer and dialog tests disabled on Firefox and Webkit due to unexpected DOM contents
3 participants