Formatted text table columns HLD and component naming conventions #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mollykreis <[email protected]>
jattasNI
requested review from
rajsite,
atmgrifter00 and
mollykreis
as code owners
mollykreis
approved these changes
May 4, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
May 8, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
atmgrifter00
approved these changes
May 8, 2023
jattasNI
changed the title
rajsite
approved these changes
May 10, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Milan Raj <[email protected]>
1 task
rajsite
added a commit
that referenced
this pull request
May 12, 2023
…1239) # Pull Request ## 🤨 Rationale As part of the vision described in #1224 in service of #1011 and other column types, we will want to share rendering logic across columns that display their data as text. This could eventually include: - the existing text column - the mapping column discussed in #1220 - columns that display numbers, dates, elapsed time, and more - columns defined in applications with custom formatting logic ## 👩💻 Implementation 1. Extract abstract base classes, templates, and styles from the existing text column for: - the column custom element - the cell view custom element - the group header custom element These live in `table-column/text-base`. 2. Derive concrete instances and register custom elements of each of these for the `text` column 3. Define and use some table field types to provide stricter typing some generic parameters ## 🧪 Testing Relying on existing tests. We have a future task to add docs/examples/tests for applications deriving from these base classes. ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: Milan Raj <[email protected]>
1 task
jattasNI
added a commit
that referenced
this pull request
Jun 15, 2023
# Pull Request ## 🤨 Rationale Need APIs for #1011 and #1014. Builds on #1224. ## 👩💻 Implementation Updates to existing HLD. Philosophy is to rely on the browser's `Intl` formatting APIs when possible and to provide modes with opinionanted configuration and with custom configuration. ## 🧪 Testing N/A ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [X] I have updated the project documentation to reflect my changes or determined no changes are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Start the HLD for #1011 and other column types that display data as text. This update focuses on shared base classes, client-specified custom colums, and possible elements that Nimble could define, not APIs for specific elements.
We previously brainstormed this in #1054 but I started a new PR for this more concrete proposal.
👩💻 Implementation
This includes the HLD and also some updates to component naming conventions which fell out of the brainstorming.
🧪 Testing
N/A
✅ Checklist