Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build of current dev is failing on Heroku #7475

Closed
yeagerm opened this issue Jul 7, 2022 · 6 comments
Closed

Build of current dev is failing on Heroku #7475

yeagerm opened this issue Jul 7, 2022 · 6 comments

Comments

@yeagerm
Copy link

yeagerm commented Jul 7, 2022

Describe the bug
From log of build attempt:

-----> Installing dependencies
       Installing node modules
       npm ERR! code EBADPLATFORM
       npm ERR! notsup Unsupported platform for [email protected]: wanted {"os":"darwin"} (current: {"os":"linux","arch":"x64"})
       npm ERR! notsup Valid OS:    darwin
       npm ERR! notsup Valid Arch:  undefined
       npm ERR! notsup Actual OS:   linux
       npm ERR! notsup Actual Arch: x64
       
       npm ERR! A complete log of this run can be found in:
       npm ERR!     /tmp/npmcache.mWHMw/_logs/2022-07-07T17_23_13_488Z-debug-0.log
-----> Build failed
@psonnera
Copy link

Same here, cgm-remote-monitor/package-lock.json specifies darwin as the OS and that's not what's Heroku wants...

bewest added a commit that referenced this issue Jul 18, 2022
npm ls fsevent didn't list any output.  I'm running on linux,
and regenerating this file after removing it seems to remove
the fsevent package from the file.
It's likely that fsevent may be used in development mode as part
of one of the build utilities, but it shouldn't block anyone from
deploying.

#7475
@sulkaharo
Copy link
Member

As discussed with Ben in private, the issue seems to be the lock file in the repo has been generated with a newer version of npm than the npm version in package.json. Heroku honors the defined node and npm versions, which then fail to interpret the file in the repo

@bewest
Copy link
Member

bewest commented Aug 8, 2022

  "engines": {
    "node": "^16.x || ^14.x || ^10.22.0 || ^12.18.4",
    "npm": "^8.x || ^6.14.6"
  },

I've removed the npm requirements line and regenerated package-lock.json using node 10.x via n 10. This lets the build succeed assuming the lowest common denominator is chosen.
#7487

@sulkaharo
Copy link
Member

We should be able to remove Node 10 and 12 from the officially supported versions, as these are not maintained anymore. OpenJS lists Node 14 as the Maintenance LTS version: https://nodejs.org/en/about/releases/

@bewest
Copy link
Member

bewest commented Aug 9, 2022

Node 10, 12, and 14 produce identical package-lock.json files using npm 6.

@bewest
Copy link
Member

bewest commented Aug 14, 2022

Should be resolved.

@bewest bewest closed this as completed Aug 14, 2022
mrspouse pushed a commit to mrspouse/cgm-remote-monitor that referenced this issue Oct 2, 2022
npm ls fsevent didn't list any output.  I'm running on linux,
and regenerating this file after removing it seems to remove
the fsevent package from the file.
It's likely that fsevent may be used in development mode as part
of one of the build utilities, but it shouldn't block anyone from
deploying.

nightscout#7475
ianchesal pushed a commit to ianchesal/cgm-remote-monitor that referenced this issue Oct 16, 2022
npm ls fsevent didn't list any output.  I'm running on linux,
and regenerating this file after removing it seems to remove
the fsevent package from the file.
It's likely that fsevent may be used in development mode as part
of one of the build utilities, but it shouldn't block anyone from
deploying.

nightscout#7475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants