rm package-lock.json && npm install #7487
Conversation
npm ls fsevent didn't list any output. I'm running on linux, and regenerating this file after removing it seems to remove the fsevent package from the file. It's likely that fsevent may be used in development mode as part of one of the build utilities, but it shouldn't block anyone from deploying. #7475
The build still fails for node 12.x. Skip optional dependencies. https://stackoverflow.com/a/48953213
|
Just FYI as I see this the branch name indicates this is work-in-progress... But I tried deploying this on a test heroku instance to work around issue reported in 7475 which I get in the latest dev. However, on this branch in the PR I continue to get the same deploy error regarding fsevents. Maybe that is not what this intends to fix. |
Remove npm list from engine as it is intended to be advisory.
…ote-monitor into wip/bewest/issue-7475
|
@bewest I deployed the latest changes again as I see there were updates since my comments. It deployed successful on my Heroku test instance 👍 It would be great to get this into dev when we are able to restore Heroku builds of the dev branch. |
This makes the testing framework and the advertised node versions match, one for one.
|
@sulkaharo I'd like to release pending |
npm ls fsevent didn't list any output. I'm running on linux,
and regenerating this file after removing it seems to remove
the fsevent package from the file.
It's likely that fsevent may be used in development mode as part
of one of the build utilities, but it shouldn't block anyone from
deploying.
#7475