Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#416] Remove sassc #423

Merged
merged 1 commit into from
Jul 5, 2023
Merged

[#416] Remove sassc #423

merged 1 commit into from
Jul 5, 2023

Conversation

andyduong1920
Copy link
Member

@andyduong1920 andyduong1920 commented Jul 3, 2023 •
edited
Loading

close #416

What happened 👀

Removed the sassc gem

Insight 📝

I tried on local following the Steps to reproduce on #404 with

  • Ruby 3.2.2
  • Rails 7.0.6
  • Without any addon

The project could be generated without any error

image

Proof Of Work 📹

No error on the rails importmap:install or rails turbo:install stimulus:install step

image

@andyduong1920 andyduong1920 self-assigned this Jul 3, 2023
@andyduong1920 andyduong1920 marked this pull request as ready for review July 3, 2023 08:36
malparty
malparty approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I tested with an older version of Ruby and the error message is clear because now it will tell "Gemfile expect ruby 3.2.2" before running into the error we used to have 🥳

Very nice that we can remove this unwanted dependency!!!! 🙏

sanG-github
sanG-github approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@sanG-github sanG-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

Base automatically changed from feature/upgrade-node-versions to develop July 5, 2023 04:03
@malparty malparty merged commit 8d47972 into develop Jul 5, 2023
@malparty malparty deleted the chore/remove-sassc branch July 5, 2023 04:03
@malparty malparty added this to the 5.7.0 milestone Jul 5, 2023
@malparty malparty mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierobert olivierobert olivierobert approved these changes

@sanG-github sanG-github sanG-github approved these changes

@malparty malparty malparty approved these changes

@rosle rosle Awaiting requested review from rosle

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@carryall carryall Awaiting requested review from carryall carryall is a code owner

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs is a code owner

@longnd longnd Awaiting requested review from longnd longnd is a code owner

@tyrro tyrro Awaiting requested review from tyrro

Assignees

@andyduong1920 andyduong1920

Labels
type : chore
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

Remove the dependency with the gem sassc
4 participants
@andyduong1920 @olivierobert @sanG-github @malparty