Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the dependency with the gem sassc #416

Closed
malparty opened this issue Jun 22, 2023 · 0 comments · Fixed by #423
Closed

Remove the dependency with the gem sassc #416

malparty opened this issue Jun 22, 2023 · 0 comments · Fixed by #423
Assignees
@andyduong1920
Labels
type : feature

Comments

@malparty
Copy link
Member

Why

The sassc gem is old and poorly updated. It is best if we can remove it before an issue occurs due to it.

Note it was added in #406 following a bug that prevented using the template. Make sure to carefully test when removing the gem.

Who Benefits?

Developers.
@malparty malparty mentioned this issue Jun 22, 2023
Merged
andyduong1920 added a commit that referenced this issue Jul 3, 2023
@andyduong1920
[#416] Remove sassc
623f384
@andyduong1920 andyduong1920 self-assigned this Jul 3, 2023
@andyduong1920 andyduong1920 mentioned this issue Jul 3, 2023
Merged
andyduong1920 added a commit that referenced this issue Jul 3, 2023
@andyduong1920
[#416] Remove sassc
a085a9f
malparty added a commit that referenced this issue Jul 5, 2023
@malparty
Merge pull request #423 from nimblehq/chore/remove-sassc
8d47972 
[#416] Remove sassc
@malparty malparty mentioned this issue Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyduong1920 andyduong1920

Labels
type : feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#416] Remove sassc nimblehq/rails-templates
2 participants
@andyduong1920 @malparty