[#223] Ignore Danger run on WIP pull request #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosharaf13
requested review from
rosle,
andyduong1920,
bterone,
byhbt,
carryall,
hoangmirs,
longnd,
malparty,
tyrro and
sanG-github
as code owners
sanG-github
reviewed
Jul 5, 2023
malparty
reviewed
Jul 6, 2023
malparty
reviewed
Jul 6, 2023
sanG-github
approved these changes
Jul 7, 2023
tyrro
reviewed
Jul 7, 2023
malparty
approved these changes
Jul 10, 2023
tyrro
reviewed
Jul 11, 2023
tyrro
approved these changes
Jul 13, 2023
| @@ -2,6 +2,7 @@ name: Test | |||
|
|
|||
| on: | |||
| pull_request: | |||
| types: [opened, edited, labeled, unlabeled, converted_to_draft, ready_for_review] | |||
There was a problem hiding this comment.
Why do we need to be so specific? Can't this be triggered just with pull_request?
There was a problem hiding this comment.
Thanks for catching the issue. Come to think of it, we don't really need an immediate workflow trigger after a PR state change, as no code has been changed.
And, just pull_request gets the job done where we make an existing open PR WIP and push commits in it; for each subsequent commit, it skips danger.
Fixed in d5fc88d
malparty
approved these changes
Jul 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #223
What happened 👀
[WIP]in it's titlewipin it's labeldraftInsight 📝
Proof Of Work 📹