Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#223] Ignore Danger run on WIP pull request #432

Merged
merged 7 commits into from
Jul 17, 2023
Merged

[#223] Ignore Danger run on WIP pull request #432

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
85d2ce6
[#223] Ignore Danger run on WIP pull request
mosharaf13 Jul 5, 2023
9a74913
[#223] Change implementation of Ignoring Danger run on WIP pull request
mosharaf13 Jul 5, 2023
7e57cc5
[#223] Have danger run skip on PR with case insensitive conditions o…
mosharaf13 Jul 6, 2023
506bcda
[#223] Fix lint in Dangerfile
mosharaf13 Jul 6, 2023
d57cfc1
[#223] Shift danger skip condition from Dangerfile to github test wor…
mosharaf13 Jul 7, 2023
b925ebc
[#223] Trigger test workflow for pr state or attribute changes
mosharaf13 Jul 13, 2023
d5fc88d
[#223] Remove immediate test workflow trigger for pr state or attribu…
mosharaf13 Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .template/addons/github/.github/workflows/test.yml.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: Test

on:
pull_request:
types: [opened, edited, labeled, unlabeled, converted_to_draft, ready_for_review]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to be so specific? Can't this be triggered just with pull_request?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the issue. Come to think of it, we don't really need an immediate workflow trigger after a PR state change, as no code has been changed.

And, just pull_request gets the job done where we make an existing open PR WIP and push commits in it; for each subsequent commit, it skips danger.

Fixed in d5fc88d

push:
branches:
- develop
Expand Down Expand Up @@ -144,7 +145,7 @@ jobs:
needs: unit_tests
runs-on: ubuntu-latest
timeout-minutes: 5
if: github.event_name == 'pull_request'
if: github.event_name == 'pull_request' && !contains(join(github.event.pull_request.labels.*.name, ','), 'wip') && !contains(github.event.pull_request.title, '[wip]') && !github.event.pull_request.draft
tyrro marked this conversation as resolved.
Show resolved Hide resolved
tyrro marked this conversation as resolved.
Show resolved Hide resolved
tyrro marked this conversation as resolved.
Show resolved Hide resolved
steps:
- uses: actions/checkout@v3
with:
Expand Down