-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Migrate to PEP517/518 packaging #128
Conversation
45a23bf
to
d27a448
Compare
Apologies for spinning this out. It kind of became one thing after another, as the installation shows up in several places that weren't being tested properly. This now:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to go AFAIC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added two minimal comments, which came from the fact that I gave a probably not-ideal example reference PR with sdcflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please feel free to merge when you're ready @esavary
@@ -1,6 +1,7 @@ | |||
attrs >= 20.1.0 | |||
furo ~= 2021.10.09 | |||
furo >= 2024.01.29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this change will work -- let's keep an eye on this. I remember pinning furo because of some weird dependency failing in more recent builds. Perhaps they figured out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built it locally.
closes Migrate packaging to PEP517/8 #127