Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Migrate to PEP517/518 packaging #128

Merged
merged 18 commits into from
Mar 21, 2024

Conversation

esavary
Copy link
Member

@esavary esavary commented Mar 12, 2024

@esavary esavary changed the title MAINT: Migrate to PEP517/518 packaging - WIP Do not merge MAINT: Migrate to PEP517/518 packaging Mar 19, 2024
@esavary esavary requested a review from effigies March 19, 2024 15:14
@effigies
Copy link
Member

Apologies for spinning this out. It kind of became one thing after another, as the installation shows up in several places that weren't being tested properly.

This now:

  1. Moves to hatch/hatch-vcs.
  2. Updates CI in various places and ensures docs build on PRs.
  3. Fixes doc build and lint issues.
  4. Tests up to Python 3.12, which was probably an overreach, but I was in there already.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to go AFAIC.

Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added two minimal comments, which came from the fact that I gave a probably not-ideal example reference PR with sdcflows.

.maint/update_requirements.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to merge when you're ready @esavary

@@ -1,6 +1,7 @@
attrs >= 20.1.0
furo ~= 2021.10.09
furo >= 2024.01.29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this change will work -- let's keep an eye on this. I remember pinning furo because of some weird dependency failing in more recent builds. Perhaps they figured out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built it locally.

@esavary esavary merged commit 62a213a into nipreps:main Mar 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate packaging to PEP517/8
4 participants