Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix Sphinx documentation configuration file #136

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

jhlegarreta
Copy link
Collaborator

  • BUG: Specify the language in Sphinx documentation config file
  • BUG: Fix DIPY doc URL in Sphinx documentation config file

Specify the language in Sphinx documentation config file.

Fixes:
```
Running Sphinx v7.2.6

Warning, treated as error:
Invalid configuration value found: 'language = None'.
Update your configuration to a valid language code.
Falling back to 'en' (English).
make: *** [Makefile:65: html] Error 2
```

raised when running:
```
make -C docs/ SPHINXOPTS="-W" BUILDDIR="$HOME/docs" OUTDIR="${CURBRANCH:-html}" html
```
Fix DIPY doc URL in Sphinx documentation config file: the URL was
changed starting DIPY 1.8.0.

Fixes:
```
Warning, treated as error:
failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://dipy.org/documentation/latest/objects.inv'
not fetchable due to
<class 'requests.exceptions.HTTPError'>: 404 Client Error:
Not Found for url: https://dipy.org/documentation/latest/objects.inv
make: *** [Makefile:65: html] Error 2
```

raised when running:
```
make -C docs/ SPHINXOPTS="-W" BUILDDIR="$HOME/docs" OUTDIR="${CURBRANCH:-html}" html
```
@@ -235,7 +235,7 @@
# Example configuration for intersphinx: refer to the Python standard library.
intersphinx_mapping = {
"bids": ("https://bids-standard.github.io/pybids/", None),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All versions pointed here should probably be synchronized with the versions specified when listing the dependencies, but that is a separate issue/PR.

@jhlegarreta jhlegarreta changed the title BUG: Fix doc build GhitHub actions workflow BUG: Fix Sphinx documentation configuration file Mar 18, 2024
@jhlegarreta
Copy link
Collaborator Author

BTW, the _version.py file is not being generated, contrary to what is said in

python -m setuptools_scm # Generate _version.py file

and

python -m setuptools_scm # Generate _version.py file

I had to call python setup.py to set up the package and create the file. That is why GitHub actions are reporting

ModuleNotFoundError: No module named 'eddymotion._version'

e.g. https://github.com/nipreps/eddymotion/actions/runs/8326718057/job/22782937133#step:6:36

Not sure if skipping that step was intentional. The call will change anyways after #128.

@effigies effigies merged commit b5b940e into nipreps:main Mar 19, 2024
8 checks passed
@jhlegarreta jhlegarreta deleted the FixDocBuildGHAWorkflow branch March 19, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants