-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft MEDIC dynamic distortion correction method #435
Conversation
The quality image from ROMEO still has NaNs in it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #435 +/- ##
===========================================
- Coverage 76.43% 66.28% -10.16%
===========================================
Files 32 33 +1
Lines 2835 3455 +620
Branches 376 416 +40
===========================================
+ Hits 2167 2290 +123
- Misses 600 1097 +497
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I still need to figure out why the results don't look good, but I was thinking an alternative might be for me to simply integrate warpkit as a dependency and run that directly. Would that be preferable to a translated Nipype workflow? |
If using warpkit significantly improves performance, all the more reason to wrap it rather than reimplement - it'll come with the added benefit of reducing longterm maintenance 😄 One hurdle that would add is a more complex installation - however if/when vanandrew/warpkit#6 is resolved it would be a cinch |
Closes #36.
This currently runs on some test data, but I haven't evaluated the results.
Changes proposed:
sdcflows.workflows.fit.medic
module with MEDIC workflow.Still to do:
EnforceTemporalConsistency
more memory-efficient.