Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: 1.2.3 #3038

Merged
merged 11 commits into from
Sep 23, 2019
Merged

REL: 1.2.3 #3038

merged 11 commits into from
Sep 23, 2019

Conversation

effigies
Copy link
Member

@effigies effigies commented Sep 19, 2019

Summary

Prep for 1.2.3 release, targeting Monday, September 23.

This is a regularly scheduled release, and the last to support Python 3.4.

Please see the 1.2.3 milestone for issues/PRs to resolve or postpone. If there's a blocking issue please comment.

For issues/PRs that will require additional time, please move them to the 1.3.0 milesteone, scheduled for Monday, October 25.

Release checklist

Uncredited authors

The following authors have contributed, but not added themselves to the .zenodo.json file. If you would like to be an author on Zenodo releases, please add yourself or comment with your preferred publication name, affiliation and ORCID. If you would like to stop being spammed whenever I'm the one doing releases, let me know, and I'll add you to a blacklist.

No entry to sort: Gio Piantoni (@gpiantoni)
No entry to sort: Victor Férat (@vferat)
No entry to sort: Isaiah Norton (@ihnorton)
No entry to sort: Niklas Förster (@niklasfoe)
No entry to sort: daniel glen (@afni-dglen)
No entry to sort: AKSoo (@Aksoo)
No entry to sort: Kirstie Whitaker (@KirstieJane)
No entry to sort: hstojic (@hstojic)
No entry to sort: Jonathan R. Williford (@williford)
No entry to sort: Hao (@anbai106)
No entry to sort: Olivia Stanley (@ostanley)
No entry to sort: Fred Mertz
No entry to sort: Kevin Sitek (@sitek)
No entry to sort: Ami Tsuchida
No entry to sort: Abel González (@abelalez)
No entry to sort: Michiel Cottaar (@MichielCottaar)
No entry to sort: Daniel Brenner (@brennerd11)

I don't think Fred Mertz is a real name, and I can't quickly find an Ami Tsuchida on GitHub, but I think I've mapped everybody else to their GitHub users.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@anbai106
Copy link
Contributor

anbai106 commented Sep 19, 2019 via email

@effigies
Copy link
Member Author

Thanks. I'll add it manually.

@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #3038 into master will increase coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3038     +/-   ##
=========================================
+ Coverage   67.03%   67.53%   +0.5%     
=========================================
  Files         343      344      +1     
  Lines       44077    44093     +16     
  Branches     5551     5555      +4     
=========================================
+ Hits        29545    29778    +233     
+ Misses      13775    13569    -206     
+ Partials      757      746     -11
Flag Coverage Δ
#smoketests 50.3% <100%> (-0.04%) ⬇️
#unittests 64.98% <100%> (+0.76%) ⬆️
Impacted Files Coverage Δ
nipype/info.py 90.14% <100%> (-4.23%) ⬇️
nipype/interfaces/dcm2nii.py 48.13% <0%> (-2.11%) ⬇️
nipype/interfaces/afni/model.py 81.95% <0%> (-0.1%) ⬇️
nipype/testing/__init__.py 88.88% <0%> (ø)
nipype/interfaces/spm/preprocess.py 57.03% <0%> (+0.32%) ⬆️
nipype/utils/filemanip.py 80.65% <0%> (+0.38%) ⬆️
nipype/interfaces/freesurfer/preprocess.py 66.11% <0%> (+0.98%) ⬆️
nipype/interfaces/freesurfer/model.py 64.25% <0%> (+1.12%) ⬆️
nipype/interfaces/io.py 54.94% <0%> (+1.88%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6314fde...dd38a83. Read the comment docs.

@effigies effigies mentioned this pull request Sep 19, 2019
1 task
@effigies effigies added this to the 1.2.3 milestone Sep 20, 2019
@djarecka
Copy link
Collaborator

@effigies - I've been testing the tutorial (didn't notice that you did it) and I actually have some issues in example_preprocessing: https://circleci.com/gh/djarecka/nipype_tutorial/209

It's fine after rerunning, but we might want to observe.

@satra
Copy link
Member

satra commented Sep 23, 2019

@djarecka - are you positive you are testing with current master? this has been an issue that i think was fixed recently.

@djarecka
Copy link
Collaborator

@satra - we're taking nipype from github (master), you can check docker builds (https://circleci.com/gh/djarecka/nipype_tutorial/209), but I was double checking and don't see anything else. As I said earlier, I've run twice, the first one failed, the second passed, and I only asked Circle to rerun...

@effigies effigies merged commit a485cf6 into master Sep 23, 2019
@effigies effigies deleted the rel/1.2.3 branch September 23, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants