Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Revision of Zenodo update script #3043

Closed
wants to merge 2 commits into from

Conversation

oesteban
Copy link
Contributor

Unlocks the first position as per private conversation with @chrisgorgo.

Unlocks first position as per private conversation with @chrisgorgo
Copy link
Member

@satra satra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add chris.g as second last (just based on academic schemas)? he was a very significant contributor for a long time, and nipype wouldn't be where it is without him.

@oesteban
Copy link
Contributor Author

This should do :)

@oesteban
Copy link
Contributor Author

Canceling CircleCI not to overload it

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #3043 into master will decrease coverage by 2.8%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3043      +/-   ##
==========================================
- Coverage   67.03%   64.22%   -2.81%     
==========================================
  Files         343      342       -1     
  Lines       44077    44030      -47     
  Branches     5551     5551              
==========================================
- Hits        29545    28277    -1268     
- Misses      13775    14634     +859     
- Partials      757     1119     +362
Flag Coverage Δ
#smoketests ?
#unittests 64.22% <ø> (ø) ⬆️
Impacted Files Coverage Δ
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/utils/logger.py 59.7% <0%> (-29.86%) ⬇️
nipype/algorithms/rapidart.py 35% <0%> (-29.42%) ⬇️
nipype/utils/provenance.py 55.73% <0%> (-28.35%) ⬇️
nipype/interfaces/spm/base.py 57.94% <0%> (-27.16%) ⬇️
nipype/interfaces/fsl/model.py 55.26% <0%> (-25.35%) ⬇️
nipype/interfaces/matlab.py 64.64% <0%> (-21.22%) ⬇️
nipype/workflows/fmri/fsl/preprocess.py 72.13% <0%> (-13.94%) ⬇️
nipype/pipeline/plugins/multiproc.py 72.22% <0%> (-12.35%) ⬇️
nipype/workflows/fmri/spm/preprocess.py 60.2% <0%> (-12.25%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6314fde...eeeb650. Read the comment docs.

@effigies
Copy link
Member

@oesteban Do you want to target the rel/1.2.3 branch and run the updated script to reorder? That would be a good demonstration that it works.

@effigies
Copy link
Member

Included in #3038.

@effigies effigies closed this Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants