MNT: Drop support for numpy < 1.15.3 #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
approved these changes
Dec 24, 2020
oesteban
reviewed
Dec 24, 2020
| # Numpy bug in python 3.7: | ||
| # https://www.opensourceanswers.com/blog/you-shouldnt-use-python-37-for-data-science-right-now.html | ||
| NUMPY_MIN_VERSION_37 = "1.15.3" | ||
| NUMPY_MIN_VERSION = "1.15.3" |
There was a problem hiding this comment.
Suggested change
| NUMPY_MIN_VERSION = "1.15.3" | |
| NUMPY_MAX_VERSION_36 = "1.20" | |
| NUMPY_MIN_VERSION = "1.15.3" |
| @@ -138,8 +137,7 @@ def get_nipype_gitversion(): | |||
| "click>=%s" % CLICK_MIN_VERSION, | |||
| "networkx>=%s" % NETWORKX_MIN_VERSION, | |||
| "nibabel>=%s" % NIBABEL_MIN_VERSION, | |||
| 'numpy>=%s ; python_version < "3.7"' % NUMPY_MIN_VERSION, | |||
| 'numpy>=%s ; python_version >= "3.7"' % NUMPY_MIN_VERSION_37, | |||
| 'numpy>=%s' % NUMPY_MIN_VERSION, | |||
There was a problem hiding this comment.
Suggested change
| 'numpy>=%s' % NUMPY_MIN_VERSION, | |
| f'numpy>={NUMPY_MIN_VERSION},<{NUMPY_MAX_VERSION_36} ; python_version < "3.7"', | |
| f'numpy>={NUMPY_MIN_VERSION} ; python_version >= "3.7"', |
|
While it's not hard to support the edge case of people using Python 3.6 and setup.py and not already having numpy installed, it might be better to let deprecated use cases fail in order to prod people to update their practices. New users should not experience this, since the docs have instructed people to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We forgot to drop support for numpy < 1.14 for the last minor release, but the next NEP29+1y milestone is Jan 7 2021, and I doubt we'll have a minor release before then. This drops support for <1.15.3, which means we can drop our split between 3.6 and 3.7+ dependencies.
Acknowledgment