Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Drop support for numpy < 1.15.3 #3284

Merged
merged 1 commit into from
Mar 31, 2021
Merged

MNT: Drop support for numpy < 1.15.3 #3284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions nipype/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,9 @@ def get_nipype_gitversion():
# versions
NIBABEL_MIN_VERSION = "2.1.0"
NETWORKX_MIN_VERSION = "2.0"
NUMPY_MIN_VERSION = "1.13"
# Numpy bug in python 3.7:
# https://www.opensourceanswers.com/blog/you-shouldnt-use-python-37-for-data-science-right-now.html
NUMPY_MIN_VERSION_37 = "1.15.3"
NUMPY_MIN_VERSION = "1.15.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NUMPY_MIN_VERSION = "1.15.3"
NUMPY_MAX_VERSION_36 = "1.20"
NUMPY_MIN_VERSION = "1.15.3"

SCIPY_MIN_VERSION = "0.14"
TRAITS_MIN_VERSION = "4.6"
DATEUTIL_MIN_VERSION = "2.2"
Expand Down Expand Up @@ -138,8 +137,7 @@ def get_nipype_gitversion():
"click>=%s" % CLICK_MIN_VERSION,
"networkx>=%s" % NETWORKX_MIN_VERSION,
"nibabel>=%s" % NIBABEL_MIN_VERSION,
'numpy>=%s ; python_version < "3.7"' % NUMPY_MIN_VERSION,
'numpy>=%s ; python_version >= "3.7"' % NUMPY_MIN_VERSION_37,
'numpy>=%s' % NUMPY_MIN_VERSION,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'numpy>=%s' % NUMPY_MIN_VERSION,
f'numpy>={NUMPY_MIN_VERSION},<{NUMPY_MAX_VERSION_36} ; python_version < "3.7"',
f'numpy>={NUMPY_MIN_VERSION} ; python_version >= "3.7"',

"packaging",
"prov>=%s" % PROV_VERSION,
"pydot>=%s" % PYDOT_MIN_VERSION,
Expand Down