Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not import minimal profile by default #144

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 13, 2022

  • environment.noXlibs breaks often things and is a hassle to use
  • documentation.enable having documentation available is desired
  • documentation.nixos.enable removes the man page for nixos-rebuild which is triggered by --help
  • programs.command-not-found.enable also command-not-found is useful

see https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/profiles/minimal.nix

@SuperSandro2000
Copy link
Member Author

github action is being flaky

@nzbr
Copy link
Member

nzbr commented Oct 16, 2022

Good idea! We should remove boot.isContainer as well due to similar quirks. Doing that also seems to help in solving #138, because isContainer changes a PAM module that's required for that to work from required to optional

A working replacement looks like this (in wsl-distro.nix):

      # We don't need a boot loader
      boot.loader.grub.enable = false;
      system.build.installBootLoader = pkgs.writeShellScript "fake-bootloader" "";
      boot.initrd.enable = false;
      system.build.initialRamdisk = pkgs.runCommand "fake-initrd" { } ''
        mkdir $out
        touch $out/${config.system.boot.loader.initrdFile}
      '';
      system.build.initialRamdiskSecretAppender = pkgs.writeShellScriptBin "append-initrd-secrets" "";

@nzbr nzbr added the bug Something isn't working label Oct 16, 2022
@SuperSandro2000
Copy link
Member Author

Lets move the removal of boot.isContainer to another PR to not open that pandoras box right now. For example I can imagine that we get problems with udev which gets activated then, audit, modprobe

@nzbr nzbr merged commit d546cd7 into nix-community:main Oct 17, 2022
@SuperSandro2000 SuperSandro2000 deleted the patch-3 branch October 17, 2022 11:54
@nzbr nzbr added the hacktoberfest-accepted This labes is used to supply people with free t-shirts label Oct 18, 2022
psvo added a commit to psvo/NixOS-WSL that referenced this pull request Nov 21, 2022
* upstream/main:
  Fix syschdemd exit code (nix-community#140)
  update remaining references to wsl.automountPath (nix-community#158)
  Update flakes (nix-community#124)
  wsl.conf: proper option types (nix-community#153)
  Fix eval by disabling module completely when wsl.enable = false (nix-community#151)
  NixOS users.users.<user> attribute name and .name can differ (nix-community#147)
  switch nixpkgs.overlays to inline overlay (nix-community#150)
  feat: native systemd support (nix-community#134)
  remove boot.isContainer (nix-community#145)
  Do not import minimal profile by default (nix-community#144)
@nzbr nzbr changed the title Do not import minimal profile by default fix: do not import minimal profile by default Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted This labes is used to supply people with free t-shirts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants