fix(docker-native): switch nixpkgs.overlays to inline overlay #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzbr
added
hacktoberfest-accepted
|
Code looks good to me. Thank you! |
psvo
added a commit
to psvo/NixOS-WSL
that referenced
this pull request
Nov 21, 2022
* upstream/main: Fix syschdemd exit code (nix-community#140) update remaining references to wsl.automountPath (nix-community#158) Update flakes (nix-community#124) wsl.conf: proper option types (nix-community#153) Fix eval by disabling module completely when wsl.enable = false (nix-community#151) NixOS users.users.<user> attribute name and .name can differ (nix-community#147) switch nixpkgs.overlays to inline overlay (nix-community#150) feat: native systemd support (nix-community#134) remove boot.isContainer (nix-community#145) Do not import minimal profile by default (nix-community#144)
nzbr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes possible for some NixOS-WSL system configs managed by a flake to use the iptables-legacy overlay, since nixpkgs.overlays could not work depending on how you use your flake. Here's some example to a person trying to use an overlay in a flake managed system
Besides this being more readable (at least for me ). this essentially makes no difference to working machines since it's just overriding the iptables package to the legacy one.